Skip to content

IECoreRenderMan : Support overscan #6742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
murraystevenson merged 2 commits into from
Jan 6, 2026
Merged

IECoreRenderMan : Support overscan #6742

murraystevenson merged 2 commits into from
Jan 6, 2026
+236 −81

Conversation

@danieldresser-ie
Copy link
Contributor

@danieldresser-ie danieldresser-ie commented Dec 16, 2025

Pretty straightforward, with just one weird floating point rounding thing, which has been documented and probably tested enough that there aren't any problems ( at least not with images smaller than 16 million pixels across ).

( Recreated with branch in the main repo, so the renderer tests run ).

@danieldresser-ie danieldresser-ie mentioned this pull request Dec 16, 2025
Closed
johnhaddon
johnhaddon reviewed Dec 16, 2025
View reviewed changes
Copy link
Member

@johnhaddon johnhaddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel! I suspect this has exposed a bug in our new display driver for XPU, since overscan isn't coming out right in XPU interactive renders (RIS top, XPU bottom) :

image

Would be good to get that sorted before merging (seems like it might be related to the crop window code you mentioned you'd been looking at anyway).

@danieldresser-ie
Copy link
Contributor Author

danieldresser-ie commented Dec 18, 2025

I've added an additional commit that overhauls the XPU display driver, addressing both your observation here and #6727.

I've tested it a fair bit interactively, and am pretty confident that it's working now, but I haven't yet added tests, and I also haven't yet addressed the non-XPU part of #6727 ( Not sure how important it is to deal correctly with changing the dataWindow interactively for non-XPU renders ).

@johnhaddon
Copy link
Member

johnhaddon commented Jan 6, 2026

I've added an additional commit that overhauls the XPU display driver, addressing both your observation here and #6727.

Thanks!

I've tested it a fair bit interactively, and am pretty confident that it's working now, but I haven't yet added tests

We already had tests from the InteractiveRenderTest base class already, but were skipping them. I've updated fa8e230 to run them for XPU (but not RIS).

I also haven't yet addressed the non-XPU part of #6727

This still represents good progress, so I intend to merge. I think any RIS fix would have to be done in Globals.cpp by recreating the RenderView rather than in Display.cpp as we were able to do for XPU. It's possible that rejigging Globals.cpp would let us move the display driver handling back to Rebind() for XPU, but we can look at that later. Hopefully we'll know soon if the fabled RenderMan show will be RIS or XPU.

@johnhaddon johnhaddon mentioned this pull request Jan 6, 2026
Open
@murraystevenson
Copy link
Contributor

murraystevenson commented Jan 6, 2026

Thanks to you both! Merging for today's release.

@murraystevenson murraystevenson merged commit 8942b6c into 1.6_maintenance Jan 6, 2026
4 of 6 checks passed
@murraystevenson murraystevenson deleted the rmanOver branch January 7, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnhaddon johnhaddon johnhaddon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danieldresser-ie @johnhaddon @murraystevenson